Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add allpods reconciler func #2112

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add Allpodslevel reconciler function in case some runtime hooks may need to consume all pods at once. It's part of the #1974.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 67.92453% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (0db9540) to head (cec725c).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.92% 12 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   68.72%   68.67%   -0.05%     
==========================================
  Files         430      430              
  Lines       40125    40233     +108     
==========================================
+ Hits        27576    27632      +56     
- Misses      10189    10228      +39     
- Partials     2360     2373      +13     
Flag Coverage Δ
unittests 68.67% <67.92%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title add allpods reconciler func koordlet: add allpods reconciler func Jun 19, 2024
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Jun 19, 2024
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@kangclzjc
Copy link
Member Author

@saintube PTAL.

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@saintube
Copy link
Member

saintube commented Jul 1, 2024

/lgtm

@saintube
Copy link
Member

saintube commented Jul 3, 2024

PTAL /cc @zwzhang0107 @hormes

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0db9ea2 into koordinator-sh:main Jul 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants